>From Ali Alsuliman <[email protected]>: Attention is currently required from: Shahrzad Haji Amin Shirazi, Ian Maxon. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17748 )
Change subject: [ASTERIXDB-3252][IDX] Fix index-only w/ UNKNOWN entries ...................................................................... Patch Set 6: (2 comments) Patchset: PS6: Could you add a regression test to make sure that it fails before the fix and now it works after the fix? File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17748/comment/bf30bf7d_08e97bba PS6, Line 460: if (!bTreeIndexKeyTypes.get(i).second) { We might need to also check if the index is 'overridingKeyFieldTypes'. Check 'QueryIndexRewriter' which uses the same method. I don't recall the exact details for the need to check both, but you should be able to find out. When you add tests, include tests that create an index on a field that is not part of the schema. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17748 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2e2163755e396678eec87771d70978e6134a9232 Gerrit-Change-Number: 17748 Gerrit-PatchSet: 6 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Shahrzad Haji Amin Shirazi <[email protected]> Gerrit-Attention: Shahrzad Haji Amin Shirazi <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Tue, 29 Aug 2023 17:29:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
