>From Ali Alsuliman <[email protected]>: Attention is currently required from: Ian Maxon. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17755 )
Change subject: [ASTERIXDB-3100][TEST]Add sleep-based tests for profiler ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS2: We should also test the JSON plan to check for the "time" in the JSON plan and how it's presented. File asterixdb/asterix-app/src/test/resources/runtimets/results/profile/sleep/sleep.3.regexjson: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17755/comment/a192f2d7_d57521c5 PS2, Line 20: "R{.+}" For the profiling tests, we should use the exact name instead of the regex. It will make it easy for us to make sense of the tests and the expected results. But don't change anything yet because we need to change the way the profile output is presented. Currently, it's difficult to make sense of the profile output. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17755 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: Ie477ba08405d2e58cb4b27d5d160e7773fc12469 Gerrit-Change-Number: 17755 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Mon, 04 Sep 2023 21:10:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
