>From Murtadha Hubail <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Murtadha Al Hubail. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17725 )
Change subject: [NO ISSUE][TX] Concurrently wirte checkpoints for atomic statements ...................................................................... Patch Set 4: (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/AtomicJobCommitMessage.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17725/comment/40a1d213_cabca1e7 PS4, Line 74: ACIDException did you check what happens if ACIDException (i.e., unchecked RuntimeException) is thrown from here? It might result in shutting down the node if it is treated as an uncaught exception. Is it okay to just throw a checked exception (e.g., HyracksDataException)? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17725 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3846bfa534ebe4077f55f3a9acccd3dc3d8d0cda Gerrit-Change-Number: 17725 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Al Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Al Hubail <[email protected]> Gerrit-Comment-Date: Wed, 06 Sep 2023 13:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
