>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Hussain Towaileb. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17751 )
Change subject: [ASTERIXDB-3255][EXT] Part1: Embed external filter values ...................................................................... Patch Set 4: (5 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/PushdownProcessorsExecutor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17751/comment/1890551c_cd9d366e PS1, Line 119: ExternalDataPrefix.containsComputedFields(configuration) && Boolean.parseBoolean( : configuration.getOrDefault(ExternalDataConstants.KEY_EMBED_FILTER_VALUES, ExternalDataConstants.TRUE)); > Should we contain all of this inside ExternalDataPrefix? Something like > ExternalDaataPrefix. […] I have no strong feeling towards any. But one can argue it's needed by the compiler only. Probably it's ok to keep all this here. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/filter/ExternalFilterValueEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17751/comment/ae109c33_8acefc41 PS4, Line 61: ArrayBackedValueStorage value, : AStringSerializerDeserializer stringSerDer > What's the difference between those 2 and the ones defined in the class? The method was changed to static. So, I have to pass those two. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/filter/embedder/ExternalFilterValueEmbedder.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17751/comment/3edf7831_cb5928ef PS4, Line 82: shouldEmbed > Does this have implementation anywhere? Not in this patch. This one would be used by Parquet's. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/filter/embedder/IExternalFilterValueEmbedder.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17751/comment/c7b31274_1fcf59e5 PS4, Line 26: IExternalFilterValueEmbedder > minor: […] Will do once we solidify everything we need from this interface :) File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/projection/ExternalDatasetProjectionFiltrationInfo.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17751/comment/6325ed55_5858c5be PS4, Line 150: embed-filter-value > minor: […] Good catch. Although it is harmless as this string would be printed in the plan. Will address in the next patch. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17751 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia61a62ab1390d9d87105898cf8c17f77c136c434 Gerrit-Change-Number: 17751 Gerrit-PatchSet: 4 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 08 Sep 2023 03:45:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hussain Towaileb <[email protected]> Gerrit-MessageType: comment
