>From Peeyush Gupta <[email protected]>:
Peeyush Gupta has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778 )
Change subject: [NO ISSUE][COMP] Disable ExtractCommonExpressionRule for
Insert/Upsert/Delete
......................................................................
[NO ISSUE][COMP] Disable ExtractCommonExpressionRule for Insert/Upsert/Delete
Change-Id: I3469da3f4f70759886fe9b98faf99eaaceff1edc
---
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java
1 file changed, 13 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/78/17778/1
diff --git
a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java
b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java
index e2ba557..571ade5 100644
---
a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java
+++
b/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java
@@ -168,12 +168,13 @@
private boolean removeCommonExpressions(Mutable<ILogicalOperator> opRef,
IOptimizationContext context)
throws AlgebricksException {
AbstractLogicalOperator op = (AbstractLogicalOperator)
opRef.getValue();
-
boolean modified = false;
// Recurse into children.
for (Mutable<ILogicalOperator> inputOpRef : op.getInputs()) {
- if (removeCommonExpressions(inputOpRef, context)) {
- modified = true;
+ if (inputOpRef.getValue().getOperatorTag() !=
LogicalOperatorTag.INSERT_DELETE_UPSERT) {
+ if (removeCommonExpressions(inputOpRef, context)) {
+ modified = true;
+ }
}
}
if (context.checkIfInDontApplySet(this, opRef.getValue())) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3469da3f4f70759886fe9b98faf99eaaceff1edc
Gerrit-Change-Number: 17778
Gerrit-PatchSet: 1
Gerrit-Owner: Peeyush Gupta <[email protected]>
Gerrit-MessageType: newchange
