>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Hussain Towaileb. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17793 )
Change subject: [ASTERIXDB-3267][EXT]: Ensure static part is also checked when evaluating for filter fields ...................................................................... Patch Set 5: (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/filter/ExternalFilterValueEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17793/comment/6abc78be_6bc99d6e PS5, Line 50: Exception Let's keep this as IOException. We should rethrow the HyracksDataException at the callers level too if we encounter a serialization problem. If we encounter a parsing exception (e.g., not parsable as number), we can simply ignore the stacktrace of that issue and a warning would suffice. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataPrefix.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17793/comment/7ef19a87_3a1b3952 PS5, Line 285: HyracksDataException We should distinguish those. We do not want to have a serialization issue in the future and we lose its stacktrace. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17793 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0c047c617887bf76623c5d30d87279c433c2f1af Gerrit-Change-Number: 17793 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2023 14:20:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
