>From Peeyush Gupta <[email protected]>:
Attention is currently required from: Peeyush Gupta.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17802
to look at the new patch set (#4).
Change subject: [NO ISSUE][COMP] Upsert into select fails on dataset with
atogenerated PK
......................................................................
[NO ISSUE][COMP] Upsert into select fails on dataset with atogenerated PK
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
An error can occur in cases when IntroduceDynamicTypeCastRule is
fired on a variable which was previously used to get type
information to apply ByNameToByIndexFieldAccessRule to change a
field access by name function to field access by index function.
With this change we modify the field access by name function to
field access by index function only after all the normalization
rules have applied.
Change-Id: Id30bf0110fc12b760edbc5ae45effa9d38044abe
---
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/create-dataset-4/create-dataset-4.03.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/create-dataset-4/create-dataset-4.01.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/create-dataset-4/create-dataset-4.04.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/create-dataset-4/create-dataset-4.05.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/create-dataset-4/create-dataset-4.02.update.sqlpp
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
A
asterixdb/asterix-app/src/test/resources/runtimets/results/ddl/create-dataset-4/create-dataset-4.07.adm
A
asterixdb/asterix-app/src/test/resources/runtimets/results/ddl/create-dataset-4/create-dataset-4.05.adm
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/index-through-object/index-through-object.9.plan
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/create-dataset-4/create-dataset-4.06.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/create-dataset-4/create-dataset-4.07.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/create-dataset-4/create-dataset-4.08.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/ddl/create-dataset-4/create-dataset-4.06.adm
16 files changed, 244 insertions(+), 10 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/02/17802/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17802
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Id30bf0110fc12b760edbc5ae45effa9d38044abe
Gerrit-Change-Number: 17802
Gerrit-PatchSet: 4
Gerrit-Owner: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-CC: Ali Alsuliman <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-MessageType: newpatchset
