>From Peeyush Gupta <[email protected]>: Attention is currently required from: Ayush Tripathi. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854 )
Change subject: Adding query queue time to stats. ...................................................................... Patch Set 1: (4 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854/comment/4460c8c7_5a23ef4c PS1, Line 7: Adding query queue time to stats. Please check other commit messages for this project and https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting and properly format the commit message. I have a created an improvement on AsterixDB JIRA as well https://issues.apache.org/jira/browse/ASTERIXDB-3277 which you can reference in your commit message. Patchset: PS1: Please check the comments and fix the failing tests. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/ResultMetadata.java: PS1: Lets update the patch such that it does not involve modifying ResultMetadata class which is Serializable. Check how compileTime is updated in the stats. In particular check handleQuery method of QueryTranslator class. File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854/comment/9204e841_93748da0 PS1, Line 68: IJobManager jobManager = : ((ClusterControllerService) appCtx.getServiceContext().getControllerService()).getJobManager(); : final JobRun run = jobManager.get(jobId); : metadata.setCreateTime(run.getCreateTime()); : metadata.setstartTime(run.getStartTime()); This can be removed once you follow the comments on ResultMetadata class. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1ff41693e7080abe5535c402d0dbb6b8bc387a37 Gerrit-Change-Number: 17854 Gerrit-PatchSet: 1 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Ayush Tripathi <[email protected]> Gerrit-Comment-Date: Mon, 09 Oct 2023 19:26:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
