>From Murtadha Hubail <[email protected]>: Murtadha Hubail has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17887 )
Change subject: [NO ISSUE][CLUS] no replica failure messages on disabled replication ...................................................................... [NO ISSUE][CLUS] no replica failure messages on disabled replication - user model changes: no - storage format changes: no - interface changes: no Details: - Do not send replica failure messages to NCs on node failures when replication is disabled. Change-Id: Ided98c584f9ba7ed81683005da86da5eab4da5d1 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17887 Integration-Tests: Jenkins <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> Reviewed-by: Ali Alsuliman <[email protected]> Tested-by: Jenkins <[email protected]> --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Murtadha Hubail: Looks good to me, but someone else must approve Ali Alsuliman: Looks good to me, approved Jenkins: Verified; Verified Objections: Anon. E. Moose #1000171: Violations found diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java index 4135f35..dde2371 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java @@ -332,6 +332,9 @@ private void notifyFailedReplica(IClusterStateManager clusterManager, String nodeID, InetSocketAddress replicaAddress) { + if (!replicationEnabled) { + return; + } LOGGER.info("notify replica failure of nodeId {} at {}", nodeID, replicaAddress); Set<String> ncs = clusterManager.getParticipantNodes(true); ReplicaFailedMessage message = -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17887 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ided98c584f9ba7ed81683005da86da5eab4da5d1 Gerrit-Change-Number: 17887 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-MessageType: merged
