>From Ian Maxon <[email protected]>:

Attention is currently required from: Till Westmann, Vijay Sarathy, 
[email protected].
Ian Maxon has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17765 )

Change subject: [ASTERIXDB-3246][COMP]: CBO costing of all physical operators 
in a query plan
......................................................................


Patch Set 19: Code-Review+2

(2 comments)

Patchset:

PS19:
minor nit but otherwise lgtm


File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/OperatorUtils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17765/comment/2dd65357_b8877dc7
PS17, Line 77:             IOptimizationContext context, 
HashMap<DataSourceScanOperator, ILogicalOperator> map) {
> Changed to use Map<>
this still should use a better name, "map" doesn't give much of a hint



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17765
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3196f664d716bb5b3806ec9a5a0dd5c1ea51ff62
Gerrit-Change-Number: 17765
Gerrit-PatchSet: 19
Gerrit-Owner: Vijay Sarathy <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Vijay Sarathy <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Attention: Till Westmann <[email protected]>
Gerrit-Attention: Vijay Sarathy <[email protected]>
Gerrit-Attention: [email protected]
Gerrit-Comment-Date: Tue, 31 Oct 2023 17:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ian Maxon <[email protected]>
Comment-In-Reply-To: Vijay Sarathy <[email protected]>
Gerrit-MessageType: comment

Reply via email to