>From Vijay Sarathy <[email protected]>: Attention is currently required from: Ali Alsuliman, Till Westmann, [email protected]. Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17765 )
Change subject: [ASTERIXDB-3246][COMP]: CBO costing of all physical operators in a query plan ...................................................................... Patch Set 21: (2 comments) File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17765/comment/6cf8212f_6d03512b PS21, Line 530: OperatorManipulationUtil.copyCardCostAnnotations(op, topOp.getValue()); > What is this for? what happened? just curious. The original order by operator (which had the input and output card annotations) was replaced by a new order by operator during this rule. Needed to copy over the annotations. File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17765/comment/0993111a_313c0868 PS21, Line 255: op.getValue().getInputs().get(0).getValue() : .getOperatorTag() == LogicalOperatorTag.NESTEDTUPLESOURCE > Why is this check? This is due to a bug in the run time of hash group by and we get wrong results in such cases. Wail said to disable hash group by in such cases for now. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17765 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3196f664d716bb5b3806ec9a5a0dd5c1ea51ff62 Gerrit-Change-Number: 17765 Gerrit-PatchSet: 21 Gerrit-Owner: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Attention: [email protected] Gerrit-Comment-Date: Wed, 01 Nov 2023 00:25:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
