>From Hussain Towaileb <[email protected]>: Attention is currently required from: Wail Alkowaileet. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17896 )
Change subject: [ASTERIXDB-3294][EXT]: Fail if there are conflicting types for computed fields ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataPrefix.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17896/comment/ad024df3_1bbf3e37 PS1, Line 204: validateIfChildField > Another possible solution: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17896/comment/e8ee8bbc_34a56760 PS1, Line 211: existingName.length() > This would throw an OutOfBoundException if both name and existingName are the > same. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17896 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I936c7afbf7e95271ede2230c08c7841a27995a21 Gerrit-Change-Number: 17896 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Thu, 02 Nov 2023 03:46:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
