>From Murtadha Hubail <[email protected]>: Attention is currently required from: Wail Alkowaileet. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17898 )
Change subject: [ASTERIXDB-3295][RT] Allow writing to empty S3 directory ...................................................................... Patch Set 1: (1 comment) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17898/comment/9874ba62_7a9962c4 PS1, Line 98: files.get(0) Since this is a static method, I would also return false if the files is !empty at the start of this method to avoid a future index out of bounds. You could then replace the two checks in line 71 by this method only. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17898 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I9f222b32316256f47488185027d3be697c0d7aac Gerrit-Change-Number: 17898 Gerrit-PatchSet: 1 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Jenkins <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Thu, 02 Nov 2023 16:28:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
