Till Westmann has posted comments on this change. Change subject: NCService documentation improvements ......................................................................
Patch Set 4: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/1490/4/asterixdb/asterix-doc/src/site/markdown/ncservice.md File asterixdb/asterix-doc/src/site/markdown/ncservice.md: PS4, Line 34: user@localhost:~/ : ➤ cd asterix-server/ : user@localhost:~/asterix-server : ➤ cd opt/local/bin In other part of the documentation we just use $ some_cmd to document shell command. I think that's simpler and it would also be more consistent to do the same here. PS4, Line 41: simply One "simply" too many. PS4, Line 70: WS PS4, Line 78: WS PS4, Line 79: WS PS4, Line 101: ncservice.png I've got an SVG for this. Could we use that instead? PS4, Line 199: ' wrong quote PS4, Line 208: ics.uci.edu Do we want to keep those hostnames in here? PS4, Line 225: WS -- To view, visit https://asterix-gerrit.ics.uci.edu/1490 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a775498e758e900013db1116fef593d292cf8af Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
