>From Hussain Towaileb <[email protected]>: Hussain Towaileb has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17927 )
Change subject: [NO ISSUE]: Make parseExpression() public ...................................................................... [NO ISSUE]: Make parseExpression() public Change-Id: I0ce04361a8aa9d849108170ed1058fb10c50ad3e Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17927 Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Reviewed-by: Hussain Towaileb <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> --- M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Murtadha Hubail: Looks good to me, approved Hussain Towaileb: Looks good to me, but someone else must approve Jenkins: Verified; Verified Objections: Anon. E. Moose #1000171: Violations found diff --git a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java index 0b9c895..dfe4c7f 100644 --- a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java +++ b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java @@ -61,7 +61,7 @@ private LangRecordParseUtil() { } - private static IAdmNode parseExpression(Expression expr) throws HyracksDataException, CompilationException { + public static IAdmNode parseExpression(Expression expr) throws HyracksDataException, CompilationException { switch (expr.getKind()) { case LITERAL_EXPRESSION: return parseLiteral((LiteralExpr) expr); -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17927 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I0ce04361a8aa9d849108170ed1058fb10c50ad3e Gerrit-Change-Number: 17927 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-MessageType: merged
