Till Westmann has submitted this change and it was merged. Change subject: Encode queries with encodeURIComponent() ......................................................................
Encode queries with encodeURIComponent() Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a Reviewed-on: https://asterix-gerrit.ics.uci.edu/1497 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Ian Maxon <[email protected]> --- M asterixdb/asterix-app/src/main/resources/queryui/js/main.js 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Ian Maxon: Looks good to me, approved Jenkins: Verified; No violations found; Verified Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-app/src/main/resources/queryui/js/main.js b/asterixdb/asterix-app/src/main/resources/queryui/js/main.js index 7a041f9..793c06e 100644 --- a/asterixdb/asterix-app/src/main/resources/queryui/js/main.js +++ b/asterixdb/asterix-app/src/main/resources/queryui/js/main.js @@ -128,7 +128,7 @@ } $scope.initDataverses = function () { - $http.get(SERVER_HOST + "/query?query=" + encodeURI(DATAVERSE_QUERY)).then(function (response) { + $http.get(SERVER_HOST + "/query?query=" + encodeURIComponent(DATAVERSE_QUERY)).then(function (response) { for (i in response.data) { $scope.dataverses.push(response.data[i].DataverseName); $scope.selected_dataverse = $scope.dataverses[0]; @@ -147,8 +147,9 @@ $scope.query = function () { var timer = new Date().getTime(); $scope.save($scope.query_input, $scope.selected_dataverse); - $http.get(SERVER_HOST + "/query?query=" + - encodeURI("use dataverse " + $scope.selected_dataverse + ";" + $scope.query_input)) + var uri = SERVER_HOST + "/query?query=" + + encodeURIComponent("use dataverse " + $scope.selected_dataverse + ";" + $scope.query_input) + $http.get(uri) .then(function (response) { $scope.results = response.data; console.log(response); -- To view, visit https://asterix-gerrit.ics.uci.edu/1497 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a04445b22258d9cc3bb258f60e91ed970e85d6a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
