>From Ian Maxon <[email protected]>: Attention is currently required from: Ali Alsuliman. Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17864 )
Change subject: [ASTERIX-3283][RT] Profile micro-ops and subplans ...................................................................... Patch Set 8: (6 comments) File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17864/comment/ea347697_f68e8651 PS7, Line 61: revert File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/ClosedRecordConstructorEvalFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17864/comment/48985210_6bcf5f56 PS5, Line 43: @Override : public String toString() { : return "ClosedRecordConstructor"; : } > Can you move the method below the constructor? Done File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/ProfiledPushRuntime.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17864/comment/a9aba425_fcfd1b50 PS7, Line 47: public ProfiledPushRuntime(IPushRuntime push, IOperatorStats stats) { > Remove unused constructor. Done File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractPushRuntimeFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17864/comment/f47ee46d_7c9aead6 PS7, Line 27: private static final long serialVersionUID = 2L; > Do we need this change? no. not anymore File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/AlgebricksMetaOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17864/comment/381767a3_06cef883 PS7, Line 280: pipeline.getRuntimeFactories()[0] > Shouldn't this be the last runtime factory based on how getStats() is used? > getStats() is called so […] yes good catch, i forgot about this when i flipped the order of traversal File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17864/comment/5ca5a10b_86e89f17 PS7, Line 75: IOperatorStats prevStats = parentStats; > The parentStats passed by the callers are not correct, I believe. […] not sure why i didn't do that in the first place. i guess it's a vestige of when i was trying to link the pushruntimes to the outer non-micro op. good idea, done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17864 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: Ib266878bf05782506045abfadaa83b41f0f9598b Gerrit-Change-Number: 17864 Gerrit-PatchSet: 8 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Tue, 14 Nov 2023 09:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
