>From Ian Maxon <[email protected]>: Ian Maxon has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17948 )
Change subject: [ASTERIXDB-3278][API] Fix hit ratio calculation ...................................................................... [ASTERIXDB-3278][API] Fix hit ratio calculation - user model changes: no - storage format changes: no - interface changes: no Details: The ratio of course needs to use floating point division, not integer. Change-Id: I568a2df4594bdde19932ba72362c9c61a96c9183 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17948 Integration-Tests: Jenkins <[email protected]> Contrib: Ian Maxon <[email protected]> Tested-by: Jenkins <[email protected]> Reviewed-by: Wail Alkowaileet <[email protected]> --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: Wail Alkowaileet: Looks good to me, approved Jenkins: Verified; Verified Ian Maxon: diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java index d1a1008..7ac1431 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java @@ -100,7 +100,7 @@ metadata.setQueueWaitTimeInNanos(run.getJobProfile().getQueueWaitTimeInNanos()); } metadata.setProcessedObjects(processedObjects); - metadata.setBufferCacheHitRatio(pagesRead > 0 ? (pagesRead - nonPagedReads) / pagesRead : Double.NaN); + metadata.setBufferCacheHitRatio(pagesRead > 0 ? (pagesRead - nonPagedReads) / (double) pagesRead : Double.NaN); metadata.setWarnings(AggregateWarnings); metadata.setTotalWarningsCount(aggregateTotalWarningsCount); if (run != null && run.getFlags() != null && run.getFlags().contains(JobFlag.PROFILE_RUNTIME)) { -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17948 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I568a2df4594bdde19932ba72362c9c61a96c9183 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 4 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-MessageType: merged
