Yingyi Bu has posted comments on this change. Change subject: Add cluster performance testing scripts. ......................................................................
Patch Set 4: (4 comments) 1) Reference results were removed from the benchmarks package. Do we still have (and use) TPC-H reference results for regression testing? They were not used and in this change we do not check result correctness. 2) The TPC-H benchmark parameterizes some queries based on the scale factor. Should we file an issue to support this as well (doesn't seem to be very urgent)? Filed AsterixDB-1793. https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/ansible/runquery.yml File asterixdb/asterix-benchmark/src/main/resources/ansible/runquery.yml: PS4, Line 61: report > Can we remove those empty lines at the end? Done https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q18.sqlpp.dis File asterixdb/asterix-benchmark/src/main/resources/benchmarks/tpch/queries/q18.sqlpp.dis: PS4, Line 20: Error > Do we use this information or can we remove it from the file? Queries with "Error" annotations are disabled. Later, we will know which queries to re-enable when we fix bugs. https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/bin/runall.sh File asterixdb/asterix-benchmark/src/main/resources/bin/runall.sh: PS4, Line 33: INVENTORY > Should we validate the inventory before we start running? Or will the ansib Done https://asterix-gerrit.ics.uci.edu/#/c/1504/4/asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml File asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml: PS4, Line 33: unhygienix > This might need to change when Ian get's a new CNAME for the machine, right Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1504 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie17f20dc87694a865aebc561d8eded064c66f5bb Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
