Taewoo Kim has posted comments on this change. Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusExpressionToPlanTranslator ......................................................................
Patch Set 17: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1434/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java: PS17, Line 187: . > Why do you need this new constructor? In FuzzyJoinRule file, it has its counter and increases it after creating this PlanTranslator. So, the PlanTranslator should be able to see the new counter value. So, either we need to create setVarCounter() or declare a new constructor. I think this new constructor might be better. -- To view, visit https://asterix-gerrit.ics.uci.edu/1434 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
