Michael Blow has posted comments on this change. Change subject: Fix the names of Let to Servlet ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1486/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java: PS6, Line 23: public static final String AQL = "/aql"; > because those enums were actually just a wrapper around a string Is there a compelling reason to revert that? Enums make switch generation much easier. -- To view, visit https://asterix-gerrit.ics.uci.edu/1486 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes