>From Mehnaz Tabassum Mahin <[email protected]>: Attention is currently required from: Vijay Sarathy. Mehnaz Tabassum Mahin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18131 )
Change subject: [NO ISSUE][COMP] Fix compile time errors in Distinct Cardinality Estimation ...................................................................... Patch Set 1: (5 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18131/comment/9a15d143_97821879 PS1, Line 452: LogicalOperatorTag > I have been advised by other team members during prior reviews that we should > not be manipulating fu […] Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/OperatorUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18131/comment/3c4e4fea_3e7d1347 PS1, Line 53: map > Earlier name (scanAndDisticntOps) was more descriptive, please use that > unless there is a good reaso […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18131/comment/cd4adecc_7cb11064 PS1, Line 61: LogicalOperatorTag tag = op.getOperatorTag(); > Same comment about not manipulating function arguments. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18131/comment/65d36309_6811e0a6 PS1, Line 180: return new Pair<>(distinctVars, distinctFunctions); > We ran into an issue (don't remember the details fully now), when > distinctVars and distinctFunctions […] Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18131/comment/dd8d96b2_3e8d30dc PS1, Line 902: parent = op; > Same comment as before about not manipulating function arguments. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18131 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ic31c3109a1f9cfc4ae12fb3a49273142973b240b Gerrit-Change-Number: 18131 Gerrit-PatchSet: 1 Gerrit-Owner: Mehnaz Tabassum Mahin <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Vijay Sarathy <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2024 06:52:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vijay Sarathy <[email protected]> Gerrit-MessageType: comment
