>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Murtadha Hubail, Ayush Tripathi, Hussain Towaileb. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18178 )
Change subject: [ASTERIXDB-3353][EXT] Fixing avro data parser for union types , adding testcases. ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: All pushdown tests are not necessary as Avro doesn't support any type of projection. Remove those. File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18178/comment/ca49aed4_25e5ebcb PS1, Line 420: Remove File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AvroDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18178/comment/6a0eeb84_897bc138 PS1, Line 91: private final void parseUnion(Schema unionSchema, Object value, DataOutput out) throws IOException { : List<Schema> possibleTypes = unionSchema.getTypes(); : for (Schema possibleType : possibleTypes) { : if (possibleType.getType() != NULL) { : parseValue(possibleType, value, out); : } : } : } How many types a UNION could have? You need to investigate if a union could have more than two types. If that the case, then this should be determined by the value type and not the possible types of the union. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18178 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I7bdaec92c4a69e807017d355023d4d46d92a3b95 Gerrit-Change-Number: 18178 Gerrit-PatchSet: 1 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ayush Tripathi <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Mon, 26 Feb 2024 17:18:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
