>From Murtadha Hubail <[email protected]>:

Murtadha Hubail has submitted this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18202 )

Change subject: [NO ISSUE][EXT] Change default max objects per file
......................................................................

[NO ISSUE][EXT] Change default max objects per file

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

- Change the default of maximum object per file in
  COPY TO from 1K to 10K to avoid writing many small
  files to external storage.

Change-Id: I793251dd17be808eb3b9faf62504e422bc644634
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18202
Integration-Tests: Jenkins <[email protected]>
Tested-by: Jenkins <[email protected]>
Reviewed-by: Murtadha Hubail <[email protected]>
Reviewed-by: Hussain Towaileb <[email protected]>
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
1 file changed, 25 insertions(+), 1 deletion(-)

Approvals:
  Murtadha Hubail: Looks good to me, but someone else must approve
  Hussain Towaileb: Looks good to me, approved
  Jenkins: Verified; Verified

Objections:
  Anon. E. Moose #1000171: Violations found




diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
index c0af89f..fc8f527 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
@@ -310,7 +310,7 @@
      */
     public static final String KEY_WRITER_MAX_RESULT = "max-objects-per-file";
     public static final String KEY_WRITER_COMPRESSION = "compression";
-    public static final int WRITER_MAX_RESULT_DEFAULT = 1000;
+    public static final int WRITER_MAX_RESULT_DEFAULT = 10000;
     public static final Set<String> WRITER_SUPPORTED_FORMATS;
     public static final Set<String> WRITER_SUPPORTED_ADAPTERS;
     public static final Set<String> WRITER_SUPPORTED_COMPRESSION;

--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18202
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I793251dd17be808eb3b9faf62504e422bc644634
Gerrit-Change-Number: 18202
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-MessageType: merged

Reply via email to