>From Utsav Singh <[email protected]>: Attention is currently required from: Hussain Towaileb. Utsav Singh has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 )
Change subject: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container ...................................................................... Patch Set 4: Code-Review+1 (5 comments) File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/a0452d4b_62ad87da PS2, Line 200: file hierarchy inside browse container > Let's also have a test that adds 1500 folders and 1500 files, we need to make > sure that we are retur […] Ack File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/e9e228c2_8eb0f978 PS2, Line 522: Map<String, List<String>> allObjects = listS3ObjectsOfSingleDepth(s3Client, container, prefix); : return allObjects; > You can just return the result directly: […] Ack https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/466c9b11_55a40bd3 PS2, Line 543: Boolean > boolean Ack https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/efbc7e07_b49e7a97 PS2, Line 546: for (S3Object object : listObjectsInterable.contents()) { > I'm not sure if this is handling the 1000+ folders/files correctly, check the > comment I added for ad […] Ack https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/d3695ab2_963db211 PS2, Line 560: for (CommonPrefix object : listObjectsInterable.commonPrefixes()) { > Same as above. Ack -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iae9d85eb9899419e63c86322cd8da2273adf89c6 Gerrit-Change-Number: 18206 Gerrit-PatchSet: 4 Gerrit-Owner: Utsav Singh <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Utsav Singh <[email protected]> Gerrit-CC: Hussain Towaileb <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 29 Mar 2024 07:08:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hussain Towaileb <[email protected]> Gerrit-MessageType: comment
