Attention is currently required from: Murtadha Hubail, Ali Alsuliman. Anon. E. Moose #1000334 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212 )
Change subject: [ASTERIXDB-3370][COMP] Collect accessed datasets/views during compilation ...................................................................... Patch Set 2: (11 comments) File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/653ec2a0_503e8ca1 PS1, Line 60: *; > We don't use *. Configure your IDE to allow listing all imports. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/ba86a828_557935c4 PS1, Line 323: inlineUdfsAndViews > we need to verify that this won't exclude cases where we would like to > actually collect the datasets […] Done File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppLoadAccessedDataset.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/ed21886c_b62aed9d PS1, Line 1: package org.apache.asterix.lang.sqlpp.rewrites.visitor > missing copyright Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/864ef899_8d214bc5 PS1, Line 33: e > rethrow this as IllegalStateException Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/e55ad6f1_32ae6743 PS1, Line 36: EntityDetails.EntityType entityType = Boolean.TRUE.equals(ExpressionUtils.getBooleanLiteral(exprs.get(3))) : ? EntityDetails.EntityType.VIEW : EntityDetails.EntityType.DATASET; > Let's check if the exprs.size > 3 before we do this check. Otherwise, default > to dataset. Done File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/16477aff_768d4045 PS1, Line 27: import java.util.*; > imports Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/e85967da_93df66d9 PS1, Line 71: .*; > imports Done File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/EntityDetails.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/ff42160a_efda7777 PS1, Line 1: package org.apache.asterix.metadata.entities; > missing copyright Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/ef5c02bf_7b1f7f84 PS1, Line 8: : DATASET, : : VIEW; > Remove unneeded spaces Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/1d157814_cfb95f9c PS1, Line 12: ; > remove Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/ca2ff899_1c0e63ce PS1, Line 17: > remove empty line Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icb2529cd876bbbf40b92635aca0aa9693e9cd154 Gerrit-Change-Number: 18212 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Anon. E. Moose #1000334 Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Tue, 02 Apr 2024 17:59:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
