>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, [email protected]. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212 )
Change subject: [ASTERIXDB-3370][COMP] Collect accessed entities during compilation ...................................................................... Patch Set 5: (4 comments) File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/a166b4cc_2401ba1e PS5, Line 207: getAccessedEntities Let's rename this variable to accessedEntities. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/08bd9482_31385d03 PS5, Line 1959: getGetAccessedEntities Let's rename this to getAccessedEntities(). File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/EntityDetails.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/2fb7bd76_33c3acbe PS5, Line 37: datasetName Let's rename this and the instance variable to entityName https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212/comment/590bec2d_506550e5 PS5, Line 52: getDatasetName Let's rename this to getEntityName() -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18212 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Icb2529cd876bbbf40b92635aca0aa9693e9cd154 Gerrit-Change-Number: 18212 Gerrit-PatchSet: 5 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-CC: [email protected] Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: [email protected] Gerrit-Comment-Date: Wed, 03 Apr 2024 19:33:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
