>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman, [email protected]. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18226 )
Change subject: [ASTERIXDB-3370][COMP] Collect and authorise dependency for views and functions ...................................................................... Patch Set 4: (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18226/comment/737965a9_6587926c PS4, Line 4226: appCtx.getReceptionist().ensureAuthorized(requestParameters, metadataProvider); It seems that we need to do something similar to other applicable handle*Statement() such as handleInsertUpsertStatement(). ensureSchedulable() may not always be called: if (stmtInsertUpsert.getReturnExpression() != null) { deliverResult(hcc, resultSet, compiler, metadataProvider, locker, resultDelivery, outMetadata, stats, requestParameters, false, stmt); } else { ... } For example, CREATE DATASET AS SELECT calls handleInsertUpsertStatement() and I believe ensureSchedulable() won't be called because stmtInsertUpsert.getReturnExpression() is actually null. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18226 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ic3b1898307f7099dba3ea135db6c2e794de27bde Gerrit-Change-Number: 18226 Gerrit-PatchSet: 4 Gerrit-Owner: [email protected] Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: [email protected] Gerrit-Comment-Date: Fri, 12 Apr 2024 21:14:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
