Ian Maxon has posted comments on this change. Change subject: Fix for integer numeric overflow in int* constructors ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1509/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt16ConstructorDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/constructors/AInt16ConstructorDescriptor.java: PS1, Line 92: short limit = -Short.MAX_VALUE Why's there a difference now in limit, aren't we always accumulating in the negative domain? PS1, Line 113: value < limit) Why does this signify an overflow? -- To view, visit https://asterix-gerrit.ics.uci.edu/1509 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cb3411bf9a808ee87f4938c60804a8d267c36d0 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
