>From Murtadha Hubail <[email protected]>: Attention is currently required from: Peeyush Gupta, Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239 )
Change subject: [NO ISSUE][OTH]: Filter records in KafkaIngestion pipeline ...................................................................... Patch Set 2: (7 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/032a2880_0389e13b PS2, Line 7: [NO ISSUE] ASTERIXDB-3383 https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/d96d69e2_4aafd819 PS2, Line 7: OTH RT Patchset: PS2: Fix commit message File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/NoOpLSMTupleFilterCallback.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/4cf3b4f9_ec6cc938 PS2, Line 38: true This should be the other way around. Filter should exclude things. File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/2ccbc65a_2f49c7f9 PS2, Line 33: storagePartitionIdx It doesn't make much sense to pass this as well as the index storagePartitionIdx as well as the index https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/65f1f2ac_f9c8da98 PS2, Line 33: before initialize? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/a0e1b283_01ad4ae7 PS2, Line 38: int storagePartitionIdx you won't need this here -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id79607bdada1cd42949cccf43390a90dda092602 Gerrit-Change-Number: 18239 Gerrit-PatchSet: 2 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2024 22:10:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
