>From Ritik Raj <[email protected]>:
Ritik Raj has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18245 )
Change subject: [ASTERIXDB-3383][RT] resolving comments
......................................................................
[ASTERIXDB-3383][RT] resolving comments
Change-Id: I694d41db144eb8375171a0913cec837ac3fdab0e
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java
3 files changed, 12 insertions(+), 7 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/45/18245/1
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
index becdbc1..923dbd4 100644
---
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
@@ -533,7 +533,6 @@
}
RecordDescriptor outputRecordDesc = new RecordDescriptor(outputSerDes,
outputTypeTraits);
- // get the Tuple filter callback
ILSMTupleFilterCallbackFactory tupleFilterCallbackFactory =
dataset.getTupleFilterCallbackFactory();
// This allows to project only the indexed fields instead of the
entirety of the record
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java
index 05a9e1a..c2229fb 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java
@@ -26,14 +26,13 @@
public interface ILSMTupleFilterCallback extends Serializable {
/**
- * Populates the state within the filter callback by fetching the state
from the provided "index"
- * and mapping it with the storage partition index, which will be utilized
for filtering
- * the tuple directed to the index "storagePartitionIdx".
+ * Initializes the filter callback
*/
void initialize(ILSMIndex index) throws HyracksDataException;
/**
- * Filter the received record based on the initialized ingestion state.
+ * This method is called on a tuple to evaluate whether the tuple meets
the criteria
+ * for filtration based on the specified filter condition.
*/
boolean filter(FrameTupleAccessor accessor, int tupleIdx);
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java
index dc271fd..011d48f 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java
@@ -24,8 +24,6 @@
public interface ILSMTupleFilterCallbackFactory extends Serializable {
/**
* Creates a callback function that utilizes the field permutation of the
incoming tuple.
- * The field tuple contains information about the position of the record,
meta, and primary key,
- * facilitating the extraction of relevant information for filtering
purposes.
*/
ILSMTupleFilterCallback createTupleFilterCallback(int[] fieldPermutation);
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18245
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I694d41db144eb8375171a0913cec837ac3fdab0e
Gerrit-Change-Number: 18245
Gerrit-PatchSet: 1
Gerrit-Owner: Ritik Raj <[email protected]>
Gerrit-MessageType: newchange
