>From Savyasach Reddy <[email protected]>: Attention is currently required from: Wail Alkowaileet. Savyasach Reddy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 )
Change subject: Add GCS Cloud Client ...................................................................... Patch Set 6: (6 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSBufferedWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/b16eccd9_f0199052 PS6, Line 102: partNumber > Why you need this? Not necessary. I noticed that ICloudBufferedWriter.upload has a return for 'amount uploaded,' so I mirrored that behaviour from S3BufferedWriter. Would you prefer I remove this? Also, could you clarify what should be returned in the upload()? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/c438d050_b5c78d8a PS6, Line 104: setChunkSize > what's the minimum/maximum for this? https://cloud.google.com/storage/docs/performing-resumable-uploads#:~:text=want%20to%20upload.-,The%20chunk%20size%20should%20be%20a%20multiple%20of%20256%20KiB,MiB%20for%20the%20chunk%20size. Minimum: 256KiB. Default: 16MiB. Recommended: 8MiB. Couldn't find maximum. File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/1f2f1234_a7495ca5 PS6, Line 35: DELETE_BATCH_SIZE > Hmm that's 10x lower than S3. […] Yes. https://cloud.google.com/storage/quotas#:~:text=Don%27t%20include%20more%20than%20100%20calls%20in%20a%20single%20request. File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/7a6f9be5_f665a441 PS6, Line 100: list > Should that also include BlobListOption.fields(Storage.BlobField. […] No, It's added when we want to fetch the size of objects. The name is always fetched. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/3eafc014_73c523d8 PS6, Line 121: seek > What's the cost of this seek? Just curious if that actually will bring > anything from the cloud and t […] Checked it using a local gcs server. No HTTP request is triggered during the seek/limit operation; data is retrieved only upon calling the read function with appropriate values set in the HTTP header "Range". https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/072aec3f_ae7b628f PS6, Line 187: DELETE_BATCH_SIZE > We probably should include a URL of the documentation that states the limit. Ack -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 6 Gerrit-Owner: Savyasach Reddy <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-CC: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Fri, 26 Apr 2024 08:24:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
