>From <[email protected]>: Attention is currently required from: Wail Alkowaileet. [email protected] has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209 )
Change subject: [WIP] Support COPY TO in parquet ...................................................................... Patch Set 30: Code-Review+1 (9 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/TextualExternalFileParquetPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/cef9fa21_84ee7652 PS19, Line 56: TextualExternalFileParquetPrinter > Not Textual. […] Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/TextualExternalFileParquetPrinterFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/66faa736_908e7b05 PS19, Line 26: TextualExternalFileParquetPrinterFactory > Rename to ParquetExternalFilePrinterFactory Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/0869cd9e_18178b29 PS19, Line 32: Object > Change it to IAType and make it private and final, Do the same whenever the > typeInfo is Object. Done File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/provider/ExternalWriterProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/2fa552da_da260feb PS19, Line 132: sourceType > Cast to IAType Done File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/FieldNamesDictionary.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/7a5d3f32_0eaa401e PS19, Line 42: getOrCreateFieldNameIndex > Similar to the original implementation, we might have collision. […] Done File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordLazyVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/4e90fb28_12646301 PS4, Line 78: switch (parentType) { > Parent should prepare the consumer. […] Done File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordLazyVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/f3f3614f_98ff1b30 PS19, Line 52: if (type.getTypeTag() != ATypeTag.OBJECT) { : throw new RuntimeException("Type Unsupported for parquet printing"); : } > This should be done at ExternalWriterProvider to fail early. […] 129 = Some of the tuples do not agree with the given schema Errors out with this message. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/343aef6f_3014f21a PS19, Line 67: GroupType groupType = (GroupType) type > What if type is not a group type? This could happen if the declared schema > does not conform the actu […] 129 = Some of the tuples do not agree with the given schema Errors out with this message. File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordVisitorUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/a99d0134_caa6ff18 PS19, Line 139: switch (primitiveTypeName) { : case INT64: : recordConsumer.addLong(bigIntValue); : break; : case FLOAT: : recordConsumer.addFloat(bigIntValue); : break; : case DOUBLE: : recordConsumer.addDouble(bigIntValue); : break; : case INT32: : case BOOLEAN: : case BINARY: : case FIXED_LEN_BYTE_ARRAY: : case INT96: : default: : throw new HyracksDataException( : "Typecast impossible from " + typeTag + " to " + primitiveTypeName); : } > Let's extract this to a function and use for all integer variants (byte, > short, int, and long) […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I40dc16969e66af09cde04b460f441af666b39d51 Gerrit-Change-Number: 18209 Gerrit-PatchSet: 30 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-CC: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Mon, 29 Apr 2024 16:31:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
