>From Ian Maxon <ima...@uci.edu>:

Attention is currently required from: Peeyush Gupta, Wail Alkowaileet, Hussain 
Towaileb.
Ian Maxon has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 )

Change subject: [ASTERIXDB-3384][DOC] Document COPY
......................................................................


Patch Set 5: Code-Review+1

(4 comments)

File asterixdb/asterix-doc/src/main/markdown/sqlpp/7_ddl_dml.md:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243/comment/b50e2851_abebf510
PS1, Line 734: localfs
> Probably it is better to keep everything as S3. […]
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243/comment/24554ac2_5785cd72
PS1, Line 752: PATH("CopyToResult/" || to_string(b))
> PATH("CopyToResult", to_string(b)) is much cleaner
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243/comment/93e7ac5d_a057c34b
PS1, Line 760: 100
> I believe this will throw an error. […]
Done


File asterixdb/asterix-doc/src/main/markdown/sqlpp/7_ddl_dml.md:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243/comment/c7228de1_eefe42de
PS3, Line 756: /
> You won't need /. […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibdacf4e6b156a3b6ef15b1420a4102c122f8bf1c
Gerrit-Change-Number: 18243
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Maxon <ima...@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <hussain.towai...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <ima...@uci.edu>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-CC: Wail Alkowaileet <wael....@gmail.com>
Gerrit-Attention: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-Attention: Wail Alkowaileet <wael....@gmail.com>
Gerrit-Attention: Hussain Towaileb <hussain.towai...@couchbase.com>
Gerrit-Comment-Date: Wed, 01 May 2024 16:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Wail Alkowaileet <wael....@gmail.com>
Gerrit-MessageType: comment

Reply via email to