>From Ali Alsuliman <ali.al.solai...@gmail.com>: Attention is currently required from: Murtadha Hubail, Michael Blow, Hussain Towaileb. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263 )
Change subject: [NO ISSUE]: Track more requests + jobs counts ...................................................................... Patch Set 2: (3 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263/comment/a64dc4dd_8415b3e6 PS2, Line 532: catch (Exception ex) { : this.appCtx.getRequestTracker().incrementFailedRequests(); : throw ex; What about ASYNC queries? Do we count them somewhere? File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IRequestTracker.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263/comment/92d5fdbf_fbc155fd PS2, Line 91: gets 'The' instead of 'gets' similar to the above ones. File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263/comment/b709e5fb_62efa2f8 PS2, Line 151: incrementCancelledJobs(); What about the jobs that are PENDING (they are in the queue and not in the activeRunMap)? They can get cancelled while they are PENDING in the queue? Is that taken care of somewhere? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18263 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I8fa31a1e6bb6b1f1bcf90c59da646fc47546fc7c Gerrit-Change-Number: 18263 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Michael Blow <mb...@apache.org> Gerrit-Attention: Hussain Towaileb <hussai...@gmail.com> Gerrit-Comment-Date: Wed, 08 May 2024 16:53:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
