>From Michael Blow <mb...@apache.org>: Michael Blow has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18269 )
Change subject: [NO ISSUE][HYR] Reduce config manager debug logging ...................................................................... [NO ISSUE][HYR] Reduce config manager debug logging Change-Id: I40d385e6cf5260b7e9e4c414c6279746b419405f Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18269 Reviewed-by: Michael Blow <mb...@apache.org> Reviewed-by: Ali Alsuliman <ali.al.solai...@gmail.com> Tested-by: Michael Blow <mb...@apache.org> Contrib: Michael Blow <mb...@apache.org> --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java 1 file changed, 22 insertions(+), 3 deletions(-) Approvals: Michael Blow: Looks good to me, but someone else must approve; Verified; No violations found Ali Alsuliman: Looks good to me, approved diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java index 85661fe..9c5a9fa 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java @@ -148,7 +148,7 @@ if (configured) { throw new IllegalStateException("configuration already processed"); } - LOGGER.debug("registering option: " + option.toIniString()); + LOGGER.trace("registering option: {}", option::toIniString); Map<String, IOption> optionMap = sectionMap.computeIfAbsent(option.section(), section -> new HashMap<>()); IOption prev = optionMap.put(option.ini(), option); if (prev != null) { @@ -160,8 +160,13 @@ registeredOptions.add(option); optionSetters.put(option, (node, value, isDefault) -> correctedMap(node, isDefault).put(option, value)); if (LOGGER.isDebugEnabled()) { - optionSetters.put(option, (node, value, isDefault) -> LOGGER.debug("{} {} to {} for node {}", - isDefault ? "defaulting" : "setting", option.toIniString(), value, node)); + optionSetters.put(option, (node, value, isDefault) -> { + if (isDefault) { + LOGGER.trace("defaulting {} to {} for node {}", option.toIniString(), value, node); + } else { + LOGGER.debug("setting {} to {} for node {}", option.toIniString(), value, node); + } + }); } } } -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18269 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I40d385e6cf5260b7e9e4c414c6279746b419405f Gerrit-Change-Number: 18269 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <hussai...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-MessageType: merged