Change in asterixdb[master]: [ASTERIXDB-3397][API]Add retriable flag to returned errors

[AsterixDB Code Review]

>From Peeyush Gupta <peeyush.gu...@couchbase.com>:

Peeyush Gupta has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18280 )


Change subject: [ASTERIXDB-3397][API]Add retriable flag to returned errors
......................................................................

[ASTERIXDB-3397][API]Add retriable flag to returned errors

- user model changes: no
- storage format changes: no
- interface changes: no

Change-Id: I65b31440b2a0570ab3d0533fde620a71476aa0b0
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionWarning.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionError.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ICodedMessage.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/AbstractCodedMessagePrinter.java
4 files changed, 31 insertions(+), 2 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/80/18280/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionError.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionError.java
index 6556b61..a25c5a2 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionError.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionError.java
@@ -52,4 +52,9 @@
     public String getMessage() {
         return message;
     }
+
+    @Override
+    public boolean isRetriable() {
+        return false;
+    }
 }
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionWarning.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionWarning.java
index 5552bb8..66b8f0e 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionWarning.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionWarning.java
@@ -44,4 +44,9 @@
     public String getMessage() {
         return message;
     }
+
+    @Override
+    public boolean isRetriable() {
+        return false;
+    }
 }
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/AbstractCodedMessagePrinter.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/AbstractCodedMessagePrinter.java
index f1eb315..6993f89 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/AbstractCodedMessagePrinter.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/AbstractCodedMessagePrinter.java
@@ -33,7 +33,8 @@

     private enum CodedMessageField {
         CODE("code"),
-        MSG("msg");
+        MSG("msg"),
+        RETRIABLE("retriable");

         private final String str;

@@ -62,7 +63,10 @@
             pw.print("{ \n\t");
             ResultUtil.printField(pw, CodedMessageField.CODE.str(), 
codedMessage.getCode());
             pw.print("\t");
-            ResultUtil.printField(pw, CodedMessageField.MSG.str(), 
JSONUtil.escape(codedMessage.getMessage()), false);
+            ResultUtil.printField(pw, CodedMessageField.MSG.str(), 
JSONUtil.escape(codedMessage.getMessage()));
+            pw.print("\t");
+            ResultUtil.printField(pw, CodedMessageField.RETRIABLE.str(), 
codedMessage.isRetriable() ? "true" : "false",
+                    false);
             pw.print("\t} \n\t");
             boolean lastMsg = i == messages.size() - 1;
             if (!lastMsg) {
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ICodedMessage.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ICodedMessage.java
index 06202c4..e2397aa 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ICodedMessage.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ICodedMessage.java
@@ -33,4 +33,6 @@
      * @return the message
      */
     String getMessage();
+
+    boolean isRetriable();
 }

--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18280
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I65b31440b2a0570ab3d0533fde620a71476aa0b0
Gerrit-Change-Number: 18280
Gerrit-PatchSet: 1
Gerrit-Owner: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-MessageType: newchange