>From Michael Blow <[email protected]>: Attention is currently required from: Ali Alsuliman, Murtadha Hubail. Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18318 )
Change subject: [NO ISSUE][OTH] Logging enhancements + query job logging ...................................................................... Patch Set 2: (2 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18318/comment/fdfaa041_852ab4e9 PS2, Line 584: if (LOGGER.isEnabled(level)) { it's not important, but these checks are redundant if we aren't doing anything requiring compute when calling log, since log will immediately call isEnabled(level) again File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/NotifyTaskFailureWork.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18318/comment/de6a4806_5df7c27b PS2, Line 69: .getMessage() why not toString()? or doesn't Hussain have some helper which does getMessage() for types that we know provide enough context? org.apache.hyracks.api.util.ErrorMessageUtil.getCauseMessage() -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18318 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Iec2c7af1b14bf99b1d11b4178be66da860dfcbf4 Gerrit-Change-Number: 18318 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Hubail Gerrit-Comment-Date: Sat, 25 May 2024 00:23:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
