>From Ali Alsuliman <[email protected]>: Ali Alsuliman has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18355 )
Change subject: [NO ISSUE][TEST] Fix tests, remove reflection ...................................................................... [NO ISSUE][TEST] Fix tests, remove reflection Change-Id: I7459118e4f43afb4dd17d3864749b38d58bbd5e6 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18355 Tested-by: Jenkins <[email protected]> Reviewed-by: Ali Alsuliman <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTrackerFactory.java 1 file changed, 13 insertions(+), 11 deletions(-) Approvals: Murtadha Hubail: Looks good to me, approved Ali Alsuliman: Looks good to me, but someone else must approve Jenkins: Verified Objections: Anon. E. Moose #1000171: Violations found diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTrackerFactory.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTrackerFactory.java index c4390fa..38fdf56 100644 --- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTrackerFactory.java +++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTrackerFactory.java @@ -19,7 +19,6 @@ package org.apache.asterix.test.dataflow; import java.lang.reflect.Field; -import java.lang.reflect.Modifier; import java.util.Map; import org.apache.asterix.common.api.INcApplicationContext; @@ -70,20 +69,10 @@ } } - static void setFinal(Field field, Object obj, Object newValue) throws Exception { - field.setAccessible(true); - Field modifiersField = Field.class.getDeclaredField("modifiers"); - modifiersField.setAccessible(true); - modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL); - field.set(obj, newValue); - } - @SuppressWarnings({ "rawtypes", "unchecked" }) static void replaceMapEntry(Field field, Object obj, Object key, Object value) throws Exception, IllegalAccessException { field.setAccessible(true); - Field modifiersField = Field.class.getDeclaredField("modifiers"); - modifiersField.setAccessible(true); Map map = (Map) field.get(obj); map.put(key, value); } -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18355 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I7459118e4f43afb4dd17d3864749b38d58bbd5e6 Gerrit-Change-Number: 18355 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-MessageType: merged
