abdullah alamoudi has posted comments on this change. Change subject: ASTERIXDB-1786: Remove Hyracks Servlets. ......................................................................
Patch Set 10: Code-Review+2 (3 comments) Few comments. Feel free to ignore the renaming ones (Your call). as for the third one, you can either address it or create a JIRA, or a todo comment for it. https://asterix-gerrit.ics.uci.edu/#/c/1508/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/ApplicationInstallationHandler.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/ApplicationInstallationHandler.java: PS10, Line 43: ApplicationInstallationHandler this should be renamed to match the convention for servlets? https://asterix-gerrit.ics.uci.edu/#/c/1508/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/WebServer.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/WebServer.java: PS10, Line 70: JSONOutputRequestHandler not sure anymore if we should rename to match the servlet naming convention. your call till https://asterix-gerrit.ics.uci.edu/#/c/1508/10/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java: PS10, Line 70: HttpMethod.POST need to understand how this affect existing servlets as they were written with the assumption that a non Get and non Post request will not get through. -- To view, visit https://asterix-gerrit.ics.uci.edu/1508 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
