>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Ali Alsuliman, Michael Blow. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445 )
Change subject: WIP: cast() improvement ...................................................................... Patch Set 6: Code-Review+2 (4 comments) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordCastingPointable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445/comment/1d05fd8c_7565251b PS6, Line 217: IllegalStateException Could use a message https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445/comment/e19ce68e_a11a0ef0 PS6, Line 443: quickSort Maybe consider using IntArrays from fastutil? They have a bunch of sort algorithms there (you can provide your comparator too). File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ACastingPointableVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445/comment/c77eca7c_e035ceab PS6, Line 141: needPromote Flip a logic to avoid '!' https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445/comment/08ad60c2_524e46e4 PS6, Line 159: needPromote This means both promote/demote, right? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id7945b8d595353f1ea82ba3f1cc87f35ee8055a2 Gerrit-Change-Number: 18445 Gerrit-PatchSet: 6 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2024 01:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
