>From Murtadha Hubail <[email protected]>:

Attention is currently required from: Peeyush Gupta, Wail Alkowaileet, Ali 
Alsuliman, Michael Blow.
Murtadha Hubail has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18565 )

Change subject: [ASTERIXDB-3472][HYR] Catch Task exceptions
......................................................................


Patch Set 2:

(2 comments)

Commit Message:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18565/comment/7838e657_de6db3ef
 
PS2, Line 16:
Add MB


File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18565/comment/ab85e846_3aea872a
PS2, Line 459: private static Exception autoClose(AutoCloseable closeable, 
Exception ex) {
             :         Exception exception = ex;
             :         try {
             :             closeable.close();
             :         } catch (Exception e) {
             :             exception = ExceptionUtils.suppress(exception, e);
             :         }
             :         return exception;
             :     }
can't you just call one of the methods in CleanupUtils?



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18565
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I5e0f1e6b906c15932a3bb7ae740b5a7c89198cae
Gerrit-Change-Number: 18565
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-Attention: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Comment-Date: Wed, 31 Jul 2024 10:22:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to