>From Wail Alkowaileet <[email protected]>:
Wail Alkowaileet has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18583 )
Change subject: [WIP] Do not inline any function on translate Change-Id:
I7da3dcabc7dc9df287a2196a9fd07b01efc9b893
......................................................................
[WIP] Do not inline any function on translate
Change-Id: I7da3dcabc7dc9df287a2196a9fd07b01efc9b893
Change-Id: I260e55eb647111bdb5d49005263ff1afc7bfb64e
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
1 file changed, 12 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/83/18583/1
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
index 077b39b..ea448c1 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
@@ -1941,15 +1941,11 @@
ILogicalExpression expr = assignOp.getExpressions().get(0).getValue();
if (expr.getExpressionTag() != LogicalExpressionTag.FUNCTION_CALL) {
+ // Inline all variables and constants
return new Pair<>(expr, assignOp.getInputs().get(0));
}
- AbstractFunctionCallExpression funcExpr =
(AbstractFunctionCallExpression) expr;
- if (funcExpr.isFunctional()) {
- return new Pair<>(expr, assignOp.getInputs().get(0));
- }
-
- //Do not inline non-functional expressions (e.g. uuid()) and keep the
assign
+ // Do not inline any function
return new Pair<>(new
VariableReferenceExpression(assignOp.getVariables().get(0)),
new MutableObject<>(assignOp));
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18583
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: goldfish
Gerrit-Change-Id: I260e55eb647111bdb5d49005263ff1afc7bfb64e
Gerrit-Change-Number: 18583
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet <[email protected]>
Gerrit-MessageType: newchange
