>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb. Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18518 )
Change subject: [NO ISSUE]: Fail multipart complete attempt on abort ...................................................................... Patch Set 10: (1 comment) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/CloudOutputStream.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18518/comment/0a647a68_d8cb7883 PS10, Line 51: if (LOGGER.isDebugEnabled()) { : LOGGER.debug("Skipping call to finish() as operation was aborted"); : } This is generally a counterproductive pattern- the debug method already checks if debug is enabled, so this is just bloating the code. It's usually reserved for when you will be doing something expensive to log. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18518 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I4677672ae2c25de889d4a83ae585a6fa54219509 Gerrit-Change-Number: 18518 Gerrit-PatchSet: 10 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 02 Aug 2024 22:18:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
