>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Brian Yen. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18564 )
Change subject: [ASTERIXDB-3473][FUN] Add support for COUNTN() aggregate function ...................................................................... Patch Set 4: (1 comment) File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractCountAggregateFunction.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18564/comment/7b59575c_cdf964ab PS4, Line 54: nullInput > I didn't understand the use of this. Let's discuss. Let's make COUNTN() similar to COUNT() where it always returns a count (never NULL or MISSING). It should return a count of 0 for the cases where the list is empty. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18564 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ib1f4ff498a0718439417c3e3fa786bc566653fef Gerrit-Change-Number: 18564 Gerrit-PatchSet: 4 Gerrit-Owner: Brian Yen <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Brian Yen <[email protected]> Gerrit-Comment-Date: Tue, 06 Aug 2024 17:33:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
