>From Murtadha Hubail <[email protected]>:

Attention is currently required from: Michael Blow.
Murtadha Hubail has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18647 )

Change subject: [NO ISSUE][OTH] Update netty dependency version
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

File asterixdb/asterix-cloud/pom.xml:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18647/comment/3e0075ad_a4a4cac6
PS2, Line 138:                    <execution>
             :                         <id>azurite</id>
             :                         <phase>${azurite.stage}</phase>
             :                         <goals>
             :                             <goal>exec</goal>
             :                         </goals>
             :                         <configuration>
             :                             <!--suppress UnresolvedMavenProperty 
-->
             :                             
<executable>${project.build.directory}/npm/node_modules/.bin/azurite-blob</executable>
             :                             
<workingDirectory>${project.build.directory}</workingDirectory>
             :                             <environmentVariables>
             :                                 
<PATH>${project.build.directory}/npm/node</PATH>
             :                             </environmentVariables>
             :                             <arguments>
             :                                 <argument>--blobPort</argument>
             :                                 <argument>15055</argument>
             :                                 <argument>--location</argument>
             :                                 
<argument>${project.build.directory}/azurite</argument>
             :                                 <argument>--debug</argument>
             :                                 
<argument>${project.build.directory}/azurite/logs/azurite-debug.log</argument>
             :                             </arguments>
             :                             <async>true</async>
             :                             
<outputFile>${project.build.directory}/azurite/logs/azurite.log</outputFile>
             :                         </configuration>
             :                     </execution>
             :                 </executions>
             :             </plugin>
             :             <plugin>
             :                 <groupId>com.github.eirslett</groupId>
             :                 <artifactId>frontend-maven-plugin</artifactId>
             :                 <version>1.13.4</version>
             :                 <configuration>
             :                     <nodeVersion>v14.15.4</nodeVersion>
             :                     <npmVersion>6.14.11</npmVersion>
             :                     
<workingDirectory>target/npm</workingDirectory>
             :                     
<installDirectory>target/npm</installDirectory>
             :                 </configuration>
             :                 <executions>
             :                     <execution>
             :                         <id>install node and yarn</id>
             :                         <goals>
             :                             <goal>install-node-and-npm</goal>
             :                         </goals>
             :                         
<phase>${azurite.npm.install.stage}</phase>
             :                     </execution>
             :                     <execution>
             :                         <id>azurite blob</id>
             :                         <phase>${azurite.install.stage}</phase>
             :                         <goals>
             :                             <goal>npm</goal>
             :                         </goals>
             :                         <configuration>
             :                             <arguments>install 
azurite</arguments>
             :                         </configuration>
             :                     </execution>
> these need to be in a profile to only run when needed
Will move the test to the job already running azurite in the subsequent change



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18647
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic94d5a260c0b3ac3ed7df29d7b473a2a20d32e7c
Gerrit-Change-Number: 18647
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-CC: Michael Blow <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Comment-Date: Wed, 14 Aug 2024 14:14:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Blow <[email protected]>
Gerrit-MessageType: comment

Reply via email to