>From Wail Alkowaileet <[email protected]>: Attention is currently required from: [email protected]. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18778 )
Change subject: [ASTERIXDB-3392] Fix format in tests ...................................................................... Patch Set 2: (1 comment) File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/provider/ExternalWriterProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18778/comment/3b9a2f74_bbc46498 PS2, Line 162: if (writerVersionString.equals(ExternalDataConstants.PARQUET_WRITER_VERSION_VALUE_1)) { : return ParquetProperties.WriterVersion.PARQUET_1_0; : } else if (writerVersionString.equals(ExternalDataConstants.PARQUET_WRITER_VERSION_VALUE_2)) { : return ParquetProperties.WriterVersion.PARQUET_2_0; : } : return ParquetProperties.WriterVersion.PARQUET_2_0; Since v1 is the default, this could be simplified as follows: if(writerVersionString.equals(ExternalDataConstants.PARQUET_WRITER_VERSION_VALUE_2) { return ParquetProperties.WriterVersion.PARQUET_2_0 } return ParquetProperties.WriterVersion.PARQUET_1_0 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18778 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I480866ba09e519f9d1242fdfdc9e2a70f7578f13 Gerrit-Change-Number: 18778 Gerrit-PatchSet: 2 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: [email protected] Gerrit-Comment-Date: Fri, 30 Aug 2024 12:57:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
