>From Hussain Towaileb <[email protected]>:

Attention is currently required from: Murtadha Hubail, Michael Blow, Hussain 
Towaileb, Mohammad Nawazish Khan.
Hussain Towaileb has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18770 )

Change subject: ASTERIXDB-3493: The storage engine should use the cloud storage 
prefix whilst writing objects to Google Cloud Storage (GCS)
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

File 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSClientConfig.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18770/comment/337c239d_89dda7a1
PS3, Line 75: of
Not related to this change specifically:
This seems to be used only by our COPY TO operations, and in the case of S3, it 
seems to be setting the prefix explicitly to an empty string, I will confirm if 
that was intention behavior or not.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18770
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I7b84bf98272581bc96851855d4bd8663780ab611
Gerrit-Change-Number: 18770
Gerrit-PatchSet: 3
Gerrit-Owner: Mohammad Nawazish Khan <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
Gerrit-Attention: Mohammad Nawazish Khan <[email protected]>
Gerrit-Comment-Date: Fri, 30 Aug 2024 14:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to