>From Ian Maxon <[email protected]>:

Attention is currently required from: Murtadha Hubail, Peeyush Gupta.
Ian Maxon has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774 )

Change subject: [ASTERIXDB-3495] Library Cloud Storage
......................................................................


Patch Set 5:

(6 comments)

File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCUdfApiServlet.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/59c5c1c2_7f35e976
PS5, Line 234: iomgr
this name sucks, pick a better one


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/a3b79f99_71a84af6
PS5, Line 235: "lib.zip"
make this a final static var


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/LibraryDeployPrepareOperatorDescriptor.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/c2dc238d_74e8b486
PS5, Line 85: iomgr
this name sucks too


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/a0c2f130_d29a6531
PS5, Line 88: "lib.zip"
make this a static final var


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/1b556ff3_6d06e9a4
PS5, Line 90: "entrypoint.py
"


File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatManager.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774/comment/13388cf4_0fc93324
PS5, Line 66: LOGGER.trace
revert



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18774
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I2c173fbdc985ea590da5315c1ce18e7610fb6af0
Gerrit-Change-Number: 18774
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-Comment-Date: Fri, 30 Aug 2024 19:02:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to