>From Murtadha Hubail <[email protected]>: Attention is currently required from: Michael Blow, Hussain Towaileb, Mohammad Nawazish Khan. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18843 )
Change subject: [ASTERIXDB-3500][STO] Fix streaming reads for Google Cloud Storage(GCS) ...................................................................... Patch Set 3: (1 comment) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18843/comment/5684287e_73a38785 PS2, Line 170: ex > Done; for your perusal. As per my previous comment, you need to pass the returned value from CleanupUtils.close(reader, ex) to the RuntimeException: throw new RuntimeException(CleanupUtils.close(reader, ex)); -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18843 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I172f0044112777aec7200a0c6ae906751ffdc5f4 Gerrit-Change-Number: 18843 Gerrit-PatchSet: 3 Gerrit-Owner: Mohammad Nawazish Khan <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Attention: Mohammad Nawazish Khan <[email protected]> Gerrit-Comment-Date: Mon, 09 Sep 2024 20:46:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Mohammad Nawazish Khan <[email protected]> Gerrit-MessageType: comment
